-
Notifications
You must be signed in to change notification settings - Fork 31
feat: add ActsTrajectoriesMerger #1824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Capybara summary for PR 1824
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
The B0 PR confirms this actually works. Just to check though, is this creating new Trajectories which point to the data in the two input collections?
If the factory doesn't own the new trajectory, what does?
0bea260
to
2414b48
Compare
2414b48
to
e7b4c13
Compare
Good point. |
The reason why I introduced this data ownership policy was to address memory issues that I had attributed to duplicate deletes due to storing the same track pointers in multiple It turned out to be a different problem entirely: insufficient clearing of the pointer vectors in JOmniFactory (cc @nathanwbrei: sometimes the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks much cleaner.
Briefly, what does this PR introduce?
This PR pulls the ActsTrajectoriesMerger and non-owning JOmniFactory Output support out of #1744.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.